Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/http, api/middleware: enhance the retry logic of the HTTP client #8229

Merged
merged 2 commits into from
Jun 3, 2024
Merged

client/http, api/middleware: enhance the retry logic of the HTTP client #8229

merged 2 commits into from
Jun 3, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7300, #8142.

What is changed and how does it work?

Schedule a member change check when the HTTP status code is 503 or receives a leader/primary change error.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label May 30, 2024
@JmPotato JmPotato requested review from rleungx and HuSharp May 30, 2024 08:30
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2024
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.69231% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 77.29%. Comparing base (199b017) to head (1794635).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8229      +/-   ##
==========================================
+ Coverage   77.26%   77.29%   +0.03%     
==========================================
  Files         471      471              
  Lines       61346    61369      +23     
==========================================
+ Hits        47401    47438      +37     
+ Misses      10383    10373      -10     
+ Partials     3562     3558       -4
Flag Coverage Δ
unittests 77.29% <82.69%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2024
@JmPotato JmPotato requested a review from HuSharp June 3, 2024 07:25
@JmPotato
Enhance the retry logic of the HTTP client
2ff6693 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
HuSharp
HuSharp reviewed Jun 3, 2024
View reviewed changes
client/errs/errno.go Outdated Show resolved Hide resolved
@JmPotato JmPotato force-pushed the enhance_http_cli_retry branch 2 times, most recently from c5592bb to ff928c1 Compare June 3, 2024 08:03
@JmPotato
Unify service discovery error message
1794635 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2024
@HuSharp
Copy link
Member

HuSharp commented Jun 3, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 1794635

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit a929a54 into tikv:master Jun 3, 2024
19 checks passed
@JmPotato JmPotato deleted the enhance_http_cli_retry branch June 3, 2024 08:38
@JmPotato JmPotato mentioned this pull request Jun 3, 2024
Merged
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 31, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 31, 2024
@JmPotato @ti-chi-bot
This is an automated cherry-pick of tikv#8229
26d4db5 
ref tikv#7300

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8464.

JmPotato added a commit to ti-chi-bot/pd that referenced this pull request Aug 1, 2024
@JmPotato
This is an automated cherry-pick of tikv#8229
bb960c7 
ref tikv#7300

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
JmPotato added a commit to ti-chi-bot/pd that referenced this pull request Aug 1, 2024
@JmPotato
Cherry-pick of tikv#8229
7d0cbf6 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 1, 2024
@ti-chi-bot @JmPotato
client/http, api/middleware: enhance the retry logic of the HTTP clie…
5e84948 
…nt (#8229) (#8464)

ref #7300

Schedule a member change check when the HTTP status code is 503 or receives a leader/primary change error.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
component/client Client logic. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JmPotato @HuSharp @ti-chi-bot @rleungx